Correctly build Lua with backwards compatibility #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variables for the Lua compatibility was changed in Lua 5.3, and overlooked in the Linux From Scratch book when updating the Lua version [1], probably using the recipe for Lua 5.2. > MYCFLAGS="-DLUA_COMPAT_5_2 -DLUA_COMPAT_5_1": This environment > variable includes compatibility layers with Lua 5.1 and 5.2 in the > build. Fix this, so that the VLC media player, depending an Lua 5.1, builds and works correctly. [1] http://www.linuxfromscratch.org/blfs/view/7.10/general/lua.html
|
I tested on rabammel with vlc-2.2.4 it dont work. ..../vlc/vlc-2.2.4-1/source/modules/lua/demux.c:55:13: error: implicit declaration of function ‘luaL_checkint’ [-Werror=implicit-function-declaration] |
|
You might need something like commit 19457db (vlc: Pass Lua compatibility ) from my branch pauls-changes-for-systemd-231. |
|
Sorry my fault it works |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the VLC media player failed, because the installed Lua package is missing the backwards compatibility with Lua 5.1, and 5.2.